Don't include '.0' on minutes and hours for durations when passed as large floats.#1517
Merged
j-bennet merged 1 commit intodbcli:mainfrom Jul 25, 2025
Merged
Conversation
Contributor
Author
|
Some additional notes on development: Since I have pgcli installed with pipx, running the tests with just $ uv pip install pre-commit
Resolved 9 packages in 3ms
Installed 9 packages in 9ms
+ cfgv==3.4.0
+ distlib==0.4.0
+ filelock==3.18.0
+ identify==2.6.12
+ nodeenv==1.9.1
+ platformdirs==4.3.8
+ pre-commit==4.2.0
+ pyyaml==6.0.2
+ virtualenv==20.32.0
$ uv run pre-commit install
pre-commit installed at .git/hooks/pre-commit
$ .git/hooks/pre-commit
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)SkippedI would also recommend some details about |
Contributor
|
@jay-knight If you submit a PR to update the contributing docs, I'll take it! |
Contributor
|
Thank you for the PR! 🍒 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was seeing duration values like
Time: 178.236s (2.0 minutes 58 seconds). This change just removes the ".0" off of the "2.0 minutes" by casting hours and minutes to ints.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).